Server Help Forum Index Server Help
Community forums for Subgame, ASSS, and bots
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   StatisticsStatistics   RegisterRegister 
 ProfileProfile   Login to check your private messagesLogin to check your private messages   LoginLogin (SSL) 

Server Help | ASSS Wiki (0) | Shanky.com
Incorrect module detach order

 
Post new topic   Reply to topic Printable version
 View previous topic  MERV and ASSS? Post :: Post Modules  View next topic  
Author Message
Goldeye
Novice


Gender:Gender:Male
Joined: Dec 15 2003
Posts: 57
Offline
PostPosted: Mon Oct 31, 2005 10:27 pm    Post subject: Incorrect module detach order Reply to topic Reply with quote
In modules.c, void DetachAllFromArena(Arena *arena)...
It detaches modules in the order they were attached, shouldn't the most recently attached module be detached first, and so on?
This has caused crashes for us in the past, where one module tried getting at free'd memory.

Our fix is to create a list in reversed order at the start of DetachAllFromArena, because apparently, there are problems if you make the list reversed in the first place.
Back to top
View users profile Send private message Add User to Ignore List Send email
Grelminar
Creator of Asss


Joined: Feb 26 2003
Posts: 378
Offline
PostPosted: Tue Nov 01, 2005 12:22 am    Post subject: Reply to topic Reply with quote
Ok, I've fixed this. Mt rev 96581a8c5969cb00f4ad77708dfb6012270fa5da.
Back to top
View users profile Send private message Add User to Ignore List Send email Visit posters website
Display posts from previous:   
Post new topic   Reply to topic    Server Help Forum Index -> ASSS Questions All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum
View online users | View Statistics | View Ignored List


Software by php BB © php BB Group
Server Load: 151 page(s) served in previous 5 minutes.

phpBB Created this page in 0.464870 seconds : 26 queries executed (89.8%): GZIP compression disabled