Server Help

[Smong]

I think there should be a green/prize callback for game.h

Code: Show/Hide /* this callback will be called whenever a a player picks up a * prize. x and y are in tiles */ #define CB_GREEN "green" typedef void (*GreenFunc)(Arena *arena, Player *p, int x, int y,    int prize); /* pycb: arena, player, int, int, int */

Also another argument in KillFunc to set the kill prize. The default points_kill module can poll clientset for the prize or game.c can preload the prize from clientset before DO_CBS(). Any custom modules can be loaded ontop and they would be able to overwrite the value (so load order would be important, possible rookie zone ops loading in wrong order).
A better way to implement this might be to use per arena interfaces, and if none are found then use clientset.

Why have control over prizes? This opens up possibilities of assigning an invalid prize # to the kill prize. The client sees this as fullcharge, but the server can detect the prize pickup and execute an event.

commands.txt vs. defs.h

[Grelminar]

Nice catch on the missing PRIZE_MULTIPRIZE.

The other two suggestions seem reasonable. I originally didn't do a CB_GREEN because I figured it would be called too often, but that's probably not a good reason not to support it.

Letting kill callbacks set the kill prize with an extra int pointer in the args sounds like the best solution. It'll default to a random value provided by clientset, of course. I think module ordering issues aren't really a big deal here, because you shouldn't be loading two modules that both try to set that value anyway.

I'll try to do all these soon.