Yes, I was building in support for more then a single death to end a killing spree
I agree with the parameter naming, good thinking, I basically tried to take these from the string.h, was thinking like: it works on string replacing const source with const dest, but it can probably use a better naming.
I didn't have any problems at all with writing it, I'm pretty sure it's 100% foolproof(Except that it doesn't do memory overflow checks)
And last but not least, the source is ofcourse included, so the linux people can compile their own binary(I currently don't have linux installed, I'm not a linux fan)
I'll attach a zipped version to this post btw.
I'm still adding more features, and have my todo list to work off, also wanted to say your spree module was really handy(If you compare my old module to this one, you'll see many improvements, some of which where derived in one form of the other from your brainstorm)
Anyway, if you'd like to work together, give me a message, I like the way you did certain things(Though obviously not all, I for one would never do a while(1) loop with an if clause in it
, don't know if that can be considered as good/bad coding though, but still you seem really creative and that's something into which I can release some energy as well)
Siaon - Sun May 02, 2004 8:41 am
Post subject:
Edit: Some bugs in this because of my bad renaming, will fix this asap.
Code: Show/Hide int strrpl(char *dest, const char *source, const char *target)
{ int number = 0; char buf[512]; if (strstr(target, source)) return -1; while (strstr(dest, source)) { strncpy(buf, dest, strstr(dest, source) - dest); buf[strstr(dest, source) - dest] = '\0'; strcat(buf, dest); strcat(buf, strstr(dest, source) + strlen(source)); strcpy(dest, buf); number++; } return number; } |
Ow divine.216, you'll love this piece of code - ha ha!
Update for no endless loops, smong, I lost the message in which you suggested better names for the variables, what were they?
Todo: Add overflow protection, as in: Probably add in int len to the parameters and add a check if an overflow would occur(Only possible if strlen dest>strlen source)[/b]
Anonymous - Mon May 03, 2004 11:07 am
Post subject:
I'll skip the critique of that code and say rather that if this kind of thing is going to be used (client macros) it would probably be much more elegant to have a module that lets you register and handles them systematically.
Anonymous - Wed Nov 24, 2004 6:29 pm
Post subject:
So yeah it's been 5 months and I forgot to upload this onto my website. Anyway here is a new version that can toggle lvz (for killer and arena), although I haven't tested it beyond compile errors.
Anonymous - Sat Apr 09, 2005 12:21 pm
Post subject:
Another update. I merged my macro expander in so the bongs can be defined on the same line as the message.
