Server Help

[Smong]

I have decided to release binaries of my damage module so others can experiment with it.

You can track damage on bots (like in my Pirates! zone) and you can also track damage on tiles (I'm planning to release my BF2142 project which has code examples for the tile damage).

It tracks, bullets, bombs, mines and thors. Although double barrel bullets aren't implemented. Bouncing stuff is implemented.

Here is the interface:

Code: Show/Hide /** called when a tracked player is killed */ typedef void (*KilledFunc)(Player *p, Player *killer, void *clos); /** user module must set new x and y coords for this players position. */ typedef void (*RespawnFunc)(Player *p, void *clos); /** called when a tile in a tracked region takes damage. x and y are the tile * damage is the amount of damage taken, freq is the owner of the weapon, * wtype is the type of the weapon that did the damage, see packets/ppk.h for * weapon types. */ typedef void (*TileDamageFunc)(Arena *arena, int x, int y, int damage,       int freq, int wtype, void *clos); /** the interface id for damage */ #define I_DAMAGE "damage-2" /** the damage interface struct */ typedef struct Idamage {    INTERFACE_HEAD_DECL    /** pos will get modified if this player is effected by a weapon,     * killfunc will get called when this player dies. currently     * killfunc is optional but respawnfunc is required. */    void (*AddFake)(Player *p, struct C2SPosition *pos,          KilledFunc killfunc, RespawnFunc respawnfunc, void *clos);    void (*RemoveFake)(Player *p);    /** call this when the fake player enters a safe zone or fires a weapon */    void (*FakePosition)(Player *p, struct C2SPosition *pos, int len);    void (*AddRegion)(Arena *arena, Region *rgn, TileDamageFunc tilefunc,          void *clos);    void (*RemoveRegion)(Arena *arena, Region *rgn); } Idamage;

When tracking bot damage you are supposed to provide a pointer to the bot's "struct C2SPosition *pos". As in both your module and the damage module will be using the same piece of mem.

Tile damage works per region. You should paint your region on and adjacent to the tiles you are interested in for good measure.

[Bak]

[Smong]

Example of tracking damage on fake players:
http://forums.minegoboom.com/viewtopic.php?p=66152#66152
_________________
ss news

[Smong]

Update
Kill callback is now asynchronous so you can safely call Add/RemoveFake inside it without a deadlock occuring.
Also added more checks if a tracked player is moved to spec.

The interface hasn't changed so it shouldn't be necessary to recompile any modules that use the damage module.

[Smong]

Update
Fixed bots not reloading settings when spawning out of spec.
Made the tile damage callback asynchronous for the same reasons as before.
Fixed possible crash when running on windows and an arena is destroyed.

[Smong]

Update
Added arena setting: Damage:IgnoreTeamDamage (default: 0).
Added support for some of the special tiles.

[JoWie]

[JoWie]

Could you recompile this for 1.4.4?

[Smong]

Ok.

[Agile]

The reason I ask is because I want to make all bombs do exactly 1000 damage to bots regardless of where they hit, and this isn't possible (to my knowledge) using regular ss settings. I could use a watchdamage callback (I think?) to do this, but it seems kind of redundant to have 2 damage watches on each bot, not to mention performance-draining and ugly coding.
-JP

[Smong]

Sorry is there a question in there? Were you asking for a modification to this module? Watchdamage only works on the contiuum client.

[Agile]

Er, I wrote the first part in the subject line which is barely noticeable.
It should read:
Smong, can you add a CB to your damage module?
The reason I ask is because I want to make all bombs do exactly 1000 damage to bots regardless of where they hit, and this isn't possible (to my knowledge) using regular ss settings. I could use a watchdamage callback (I think?) to do this, but it seems kind of redundant to have 2 damage watches on each bot, not to mention performance-draining and ugly coding.
-JP

[Smong]

Ok I might look into adding a callback for bot damage this weekend. The main reason I didn't do it in the first place is some weapon settings could cause it to spam callbacks causing a performance hit on the server.

[Goldeye]

Any chance of getting the source for this, Smong?

[JoWie]

Update

• Fixed EMP bomb and bouncing bomb damage (emp bombs were normal damage; bouncing bomb would do normal damage after the last bounce; bouncing emp bomb used EBombDamagePercent and not EBombDamagePercent WITH BBombDamagePercent)
  
• Region damage tracking now uses EBombDamagePercent and BBombDamagePercent
  
• Added EMP Bomb Shutdown
  

(everything else in this module is made by smong)

Contact me, not smong for any issues with this release.

[Bak]

How did you get the source?

[Initrd.gz]

[JoWie]

I asked smong... But he asked me not to release the source.

We needed the source for Command & Conquer because we will most likely move to a different server which requires a recompile in a few weeks. There are also some issues that need to be resolved. (for example, i want to track energy myself, so I am going to add a callback for fake players in the same way as in TileDamageFunc).
So because smong kinda left subspace he gave us the source

Also, for those interested, the following things are not (yet) implemented in damage:

• player interpolation (perhaps use http://www.ssforum.net/index.php?showtopic=19720)
  
• multifire
  
• burst
  
• shrapnel (does any one know how random shrapnel works?)
  
• repel
  
• wormhole gravity
  

Currently, on my todo list is the callback I mentioned above, bricks, multifire and double barrel

[JoWie]

Update

• Added additional information about weapons to TileDamageFunc
  
• New: FakeDamageFunc, allows you to watch damage on turrets
  
• New: "manageenergy" boolean in the AddFake method. If this is set to false the damage module will NOT track the fake players energy and you will have to use FakeDamageFunc to track it yourself. The old behavior is true.
  
• tick_t values now use the TICK_DIFF, TICK_GT, TICK_MAKE macro's
  
• moved all cfg->GetInt to AA_CREATE | AA_CONFCHANGED instead of reading it on every weapon fire, weapon hit, etc.
  

The interface has changed! So you will need to modify and recompile any modules that uses damage

[Dr Brain]

I don't think anyone else uses this, because it's so limited and can't be extended (because of the closed source). I know at least HS and HZ can't use it, because it isn't compiled against our cores. Add to the fact that it's author has left the game, and I doubt you'll get many takers.
_________________
Hyperspace Owner

Smong> so long as 99% deaths feel lame it will always be hyperspace to me

[JoWie]

Above changes is what I needed myself. All I did extra is upload it here.

I will be willing to help others compile. But it still creates a dependency on a 3rd party (me/smong). Which is one of the reasons I wanted the source myself.

I would have put up the source if smong hadn't asked not to do so.

[Chambahs]

id sell the source to the highest bidder, ive got a copy, no lies.

[JoWie]

• Updated for ASSS 1.5.0rc1
  
• Double barrel support
  
• Fixed a small bug where TICK_GT(current_ticks(), 0) could occur (overflowed into negative)
  
• weapons no longer hit dead players
  

I have tested a bunch of radius' and they match up to continuum.
Modified so that it makes sense out of context:

Code: Show/Hide offset2 = shipradius * 0.7; if (shipradius == 14) // special case, probably for VIE compatability    offset1 = offset2; else    offset1 = offset2 + 1; sin(i * PI / 20) // double barrel 1(left one with rot = 0) barrel1->x += round(offset1 * ( sin(((pos->rotation + 30) % 40) * PI / 20) )); barrel1->y -= round(offset1 * ( sin(pos->rotation) * PI / 20 )); // double barrel 2 (right one with rot = 0) barrel2->x -= round(offset2 * ( sin(((pos->rotation + 30) % 40) * PI / 20) )); barrel2->y += round(offset2 * ( sin(pos->rotation) * PI / 20 ));

When one of the barrels hits a player, both are removed, only one counts for damage.


Will compile windows version if needed

[Cheese]

im curious, because a bunch of my 1.4.4 modules do not work with 1.5, what did you change to make it work?


also:
1 radius + 1 radius = 2 radii
:)
_________________
SSC Distension Owner
SSCU Trench Wars Developer

[JoWie]

• Removed damage->FakePosition (no longer needed due to CB_PPK) so use game->FakePosition instead
  
• Minor changes in the naming in the interface
  
• Other modules can now track weapon fire, weapon hit and loop over all the weapons in an arena. The weapon data can not be modified however
  

Linux version is compiled against trunk 1137. Windows version is compiled against the ASSS 1.5.0rc2 release.

Example:

Code: Show/Hide #include <stdio.h> #include <stdlib.h> #include <stdbool.h> #include "asss.h" #include "damage.h" static Imodman      *mm; static Iarenaman    *aman; static Iplayerdata   *pd; static Idamage      *damage; static Ilogman      *lm; static int arenaKey  = -1; static int playerKey = -1; struct ArenaData { }; #define PlayerData PlayerData_ struct PlayerData {    Arena *arena; }; static struct ArenaData* GetArenaData(Arena *arena) {         struct ArenaData *adata = P_ARENA_DATA(arena, arenaKey);         return adata; } static struct PlayerData* GetPlayerData(Player *p) {         struct PlayerData *pdata = PPDATA(p, playerKey);         if (p->arena && p->arena != pdata->arena)         {                 pdata->arena = p->arena;            //...         }         return pdata; } static void newWeaponCB(Arena *arena, DamageWeapon *wpn) {    lm->LogP(L_INFO, "damagetest", wpn->p, "Added a weapon (%p) at %d, %d", wpn, wpn->x / 1000, wpn->y / 1000); } static void removeWeaponCB(Arena *arena, DamageWeapon *wpn, u8 removereason) {    const char *reason;    switch (removereason)    {       case DAMAGE_REMOVEWPN_HIT:          reason = "Hit a tile";       break;       case DAMAGE_REMOVEWPN_HITPLAYER:          reason = "Hit a player";       break;       case DAMAGE_REMOVEWPN_OTHERBARRELHIT:          reason = "Other barrel hit a player";       break;       case DAMAGE_REMOVEWPN_SHIPFREQCHANGE:          reason = "Firer changed ship / freq";       break;       case DAMAGE_REMOVEWPN_LEAVEARENA:          reason = "Firer left the arena";       break;       case DAMAGE_REMOVEWPN_EXPIRED:          reason = "Weapon expired";       break;       case DAMAGE_REMOVEWPN_SAFEZONE:          reason = "Firer entered a safe zone";       break;       default:          reason = "UNKNOWN";       break;    }    lm->LogP(L_INFO, "damagetest", wpn->p, "Removed a weapon(%p) at %d, %d. Because: %s", wpn, wpn->x / 1000, wpn->y / 1000, reason); } static void weaponsUpdatedCB(Arena *arena, ticks_t now) {    static DamageWeapon* lastFound = NULL;    DamageWeapon *wpn;    Link *link;    damage->WeaponLock(arena);    FOR_EACH_DAMAGEWEAPON(wpn, arena)    {       if (wpn->wpn.type == W_THOR)       {          if (wpn != lastFound)          {             lm->LogA(L_INFO, "damagetest", arena, "Found a thor while looping over all the current weapons! (only displayed once)");             lastFound = wpn;          }          break;       }    }    damage->WeaponUnlock(arena); } EXPORT const char info_template[] = "DamageTest"; static void ReleaseInterfaces() {         mm->ReleaseInterface(aman   );         mm->ReleaseInterface(pd     );         mm->ReleaseInterface(damage );         mm->ReleaseInterface(lm     ); } EXPORT int MM_damagetest(int action, Imodman *mm_, Arena *arena) {         if (action == MM_LOAD)         {                 mm      = mm_;                 aman    = mm->GetInterface(I_ARENAMAN        , ALLARENAS);                 pd      = mm->GetInterface(I_PLAYERDATA      , ALLARENAS);                 damage  = mm->GetInterface(I_DAMAGE        , ALLARENAS);                 lm      = mm->GetInterface(I_LOGMAN        , ALLARENAS);                 if (!aman || !pd || !damage || !lm)                 {                         ReleaseInterfaces();                         printf("<damagetest> Missing interfaces");                         return MM_FAIL;                 }                 arenaKey = aman->AllocateArenaData(sizeof(struct ArenaData));                 playerKey = pd->AllocatePlayerData(sizeof(struct PlayerData));                 if (arenaKey == -1 || playerKey == -1) // check if we ran out of memory                 {                         if (arenaKey  != -1) // free data if it was allocated                                 aman->FreeArenaData(arenaKey);                         if (playerKey != -1) // free data if it was allocated                                 pd->FreePlayerData (playerKey);                         ReleaseInterfaces();                         return MM_FAIL;                 }                 return MM_OK;         }         else if (action == MM_UNLOAD)         {                 aman->FreeArenaData(arenaKey);                 pd->FreePlayerData(playerKey);                 ReleaseInterfaces();                 return MM_OK;         }         else if (action == MM_ATTACH)         {       damage->AddWeaponCallback(arena, newWeaponCB, removeWeaponCB, weaponsUpdatedCB);                 return MM_OK;         }         else if (action == MM_DETACH)         {       damage->RemoveWeaponCallback(arena, newWeaponCB, removeWeaponCB, weaponsUpdatedCB);                 return MM_OK;         }         return MM_FAIL; }