Server Help

[Quan Chi2]

I got flammed the last time for asking a question like this.. But is this correct? Whats wrong with it? It compiles...with 0 errors or warnings

Code: Show/Hide          }                if (c->check("fgpic1"))                {                   sendPrivate(p, "*objon 1");                }                else if (c->check("fgpicoff"))                {                   sendPrivate(p, "*objoff 1");                }                if (c->check("fgpic2"))                {                   sendPrivate(p, "*objon 2");                }

[Bak]

perfect... now just put it in the right place
_________________
SubSpace Discretion: A Third Generation SubSpace Client

[Quan Chi2]

lol

[Mr Ekted]

How about decent formatting (ie ekted style):

Code: Show/Hide if (c->check("fgpic1"))    sendPrivate(p, "*objon 1"); else if (c->check("fgpicoff"))    sendPrivate(p, "*objoff 1"); if (c->check("fgpic2"))    sendPrivate(p, "*objon 2");

_________________
4,691 irradiated haggis!

[CypherJF]

That's just nevermind anyways.
_________________
Performance is often the art of cheating carefully. - James Gosling

[Donkano]

[Mr Ekted]

Your way is gay. My way is perfect.

[Assassin2684]

I dont know, i kinda like baks way but then agin i like everythign neat. So my code is always perfect

[Donkano]

[Bak]

I usually use Quan's way for multi line braces and Ekted's way for single line braces (or lack of them). Although I'd probably put an empy line before that final 'if' or change it to an 'else if'. At this point it's whatever feels right.

[Mr Ekted]

[Cerium]

Ish. Youre all wrong:

Code: Show/Hide if (c->check("fgpic1")) {    sendPrivate(p, "*objon 1"); } else if (c->check("fgpicoff")) {    sendPrivate(p, "*objoff 1"); } if (c->check("fgpic2")) { sendPrivate(p, "*objon 2"); }

_________________
There are 7 user(s) ignoring me right now.

[Maverick]

I would do it like Cerium but its more or less a coder's etiquette to code without brackets when there is only one line to be executed after an if() statement.
_________________

Nickname: Maverick (I changed my name!)
TWCore developer | Subspace statistics

[Mr Ekted]

It's a question of readability. Less is more. Adding braces that are redundant is bad. Adding braces at the end or the beginning of a statement is the worst place for them. When you make a list of items, do you do this?:

Here's my intro text: List item 1
List item 2
List item 3
List item 4. Here's the summary text.

No! You do this:

Here's my intro text:

List item 1
List item 2
List item 3
List item 4

Here's the summary text.

Everything that is part of the list is indented, even the numbers or the bullets. Likewise in code:

Code: Show/Hide if (...)    single-line-statement; else    {    multi;    line;    statement;    }

Every statement at the same level lines up. All start/end braces at the same level line up. Most people code like they do because it's the way they were taught, not what makes sense. It's just like religion. People are sheep.

[Smong]

I prefer opening and closing braces to be on the same level so I can read the code quickly. Although I sometimes shove everything on one line if it's a short java accessor/mutator or small try/catch block (could be 8 lines otherwise).

[Maverick]

[Donkano]

The way I posted is the way I would go about it if it was a big script, if it was a small script (less than 60 lines) I would go like this:

Code: Show/Hide if (c->check("fgpic1")) {   sendPrivate(p, "*objon 1"); } else if (c->check("fgpicoff")) {   sendPrivate(p, "*objoff 1"); } if (c->check("fgpic2")) {   sendPrivate(p, "*objon 2"); }

Everything lines up and it is neat. Brackets get a 1 space indent and the content in it gets a 2 space indent.




Edit:
And it isn't showing up the 1st spaces.

[Cyan~Fire]

Ekted's way is obviously the way to go. Everybody gives so much weight to spacing everything out these days, it's retarded. Yes, I know really spaced out code is easier to skim, but if each block is well-commented, then there's no reason to skim the code.
_________________
This help is informational only. No representation is made or warranty given as to its content. User assumes all risk of use. Cyan~Fire assumes no responsibility for any loss or delay resulting from such use.
Wise men STILL seek Him.

[Bak]

so when you do a function, the braces start indented rather than against the left border?

[D1st0rt]

I'm going to have to agree with Ekted here, and cite his style specifications, which I agree with about 95%:


_________________

[CypherJF]

interesting; i agree with most of that, 'cept the method/function body not being indented.

[D1st0rt]

Thats the part I don't agree with him on, I like to indent too

[CypherJF]

It's really non-sense as I stated earlier. Most IDEs provide the templated formatting. If not, you can find a lot of free code formatters/cleaners. We discussed in the Wisconsin Java Group, how it's much more efficient for a programmer to program his/her own style, run a cleaner/formatter to company standard, and then commit it. He did put the caveat that one should not run "diff" without formatting the code first .

[Mr Ekted]

[CypherJF]

NoOo.. lol. Seek post #46669.