Server Help

[Guest]

Hey there,

I made a bot, and if a player comes in a "box" it will be warped to a turretpoint. I made a feature that if there is already a person at the turretpoint, the next person entering the warp box will be warped to the alternative turretpoint. Though the bot doesn't agree with me and keeps warping him to the same turretpoint. Who wants to help me?

-Arctica

PS: the code:

[Guest]

lol ops, used quote instead of code ;/

[Solo Ace]

I find your code pretty disturbing, but whatever, I'm not in the mood to fix that for you.

Maybe a quote from a post I made in some thread can help you.

[Cyan~Fire]

Code: Show/Hide case EVENT_Tick:       {          for (int i = 0; i < 4; ++i)             --countdown[i];          Player *p = (Player*)event.p[0];                                                 turrpoint1=0;                                                _listnode <Player> *parse2 = playerlist->head;          while(parse)          {             Player *p = parse2->item;             if(level == 0)             {                if(p->tile.x >= 89 && p->tile.x <= 91 && p->tile.y >= 18 && p->tile.y <= 20)                {                   turpoint1++;                }             }                                                                 parse2 = parse->next;          } Then later: case EVENT_PlayerMove:       {          Player *p = (Player*)event.p[0];          if(p->tile.x >= 502 && p->tile.x <= 503 && p->tile.y >= 512 && p->tile.y <= 513)          {             if(level == 0 && turpoint1 == 0)             {                sendPrivate(p, "*warpto 90 19");                sendPrivate(p, "You are warped to turretpoint 1.");             }          }          if(p->tile.x >= 502 && p->tile.x <= 503 && p->tile.y >= 512 && p->tile.y <= 513)          {             if(level == 0 && turpoint1 != 0)             {                sendPrivate(p, "*warpto 90 24");                sendPrivate(p, "Turrentpoint occupied, alternative warping..");             }

That is so much easier to read, you shoulda re-posted.

First of all, the two if statements at the bottom (if(p->tile.x >= 502 && p->tile.x <= 503 && p->tile.y >= 512 && p->tile.y <= 513)) should be combined, as they both have the same condition.

Second, can people get to the turretpoint other than by warping? If not, you should just have a boolean that you set when you warp them, and then check that boolean instead of cycling through all the players. Even if they can get there otherwise, don't do it every tick. That's far too slow and also there will be some players that haven't moved so it will be pointless to check them. Check to see if anyone's at the turretpoint on EVENT_PlayerMove.

And this is just my preference, but I think it's easier for the coder and for people reading the code just to make a sort of macro, something like:

Code: Show/Hide #define LIMIT(value, left, right) \    (value >= left && value <= left)

It will make the code much easier to read.
_________________
This help is informational only. No representation is made or warranty given as to its content. User assumes all risk of use. Cyan~Fire assumes no responsibility for any loss or delay resulting from such use.
Wise men STILL seek Him.

[The Arctica]

sorry bout the code, and that guest was me, anyways, it can leave also and then the bool will be still at true/false so it wouldnt change.