Server Help

[tansey]

I've had several people ask me in game for how to make a bot take a vote. Since I can't spare the hours ( days ) it would take to teach people about object oriented design and then show them how my bot does it, I wrote a tutorial using only the 3 files most people use in MERV. Lemme know what you guys think:

http://www.sectionops.net/er/voting.html

--tansey

[Bak]

Another way to do it would be to keep track of the votes using the player tags mervbot provides:

Code: Show/Hide #define VOTING_TAG      6326 enum _VotePossibilities {    VOTE_Obstain,  // leave this one at the start    // add whatever you want here    VOTE_Dodgeball, // 1    VOTE_Football, // 2    VOTE_Hockey, // 3    VOTE_Count // leave this one at the end }; struct VoteResults {     int results[VOTE_Count]; }; void botInfo::vote(int value, Player *p) {      if (value > 0 && value < VOTE_Count);          set_tag(p,VOTING_TAG,value); } void botInfo::resetVotes() {     for (_listnode <Player> *parse = playerlist->head; parse; parse = parse->next)     {         set_tag(parse->item,VOTING_TAG,VOTE_Obstain);     } } VoteResults botInfo::getResults() {      VoteResults vr;      for (int x = 0; x < VOTE_Count;++x)         vr.results[x] = 0;      for (_listnode <Player> *parse = playerlist->head; parse; parse = parse->next)      {          if (parse->item != me)          {               int vote = get_tag(parse->item,VOTING_TAG);               vr.results[vote]++;          }      }     return vr; }

_________________
SubSpace Discretion: A Third Generation SubSpace Client

[tansey]

No, I'm not. countVotes() calls votes.clear(), which blows away all the nodes in the list.

[D1st0rt]

I would think all you really have to do is modify the elim plugin, because it has voting built in
_________________

[CypherJF]

this is wrong.. way wrong.


I wasn't happy w/ something someone brought to my attention so ill post my suggested edits:

spawn.h

Code: Show/Hide VoteResults getResults();

replace with

Code: Show/Hide VoteResults* botInfo::getResults();

spawn.cpp

Code: Show/Hide VoteResults* botInfo::getResults() {      VoteResults vr;      for (int x = 0; x < VOTE_Count;++x)         vr.results[x] = 0;      for (_listnode <Player> *parse = playerlist->head; parse; parse = parse->next)      {          if (parse->item != me)          {               int vote = get_tag(parse->item,VOTING_TAG);               vr.results[vote]++;          }      }     return &vr; }

I'm still debating whether or not to mention anything about having the linked list in a for-statement. Not that it's "wrong". Just... meh.

Example Use

Code: Show/Hide VoteResults *vr = getResults(); int res1 = vr->results[0];

_________________
Performance is often the art of cheating carefully. - James Gosling

[Bak]

see the problem with that Cypher is it doesn't work. VoteResults is a declared in the scope of the function getResults. After the function the memory it used may be used for other things, so if you use a pointer to it, there's no guarentee it hasn't changed (in fact, it probably has). You could declare it on the heap and force the user to free() or delete the memory after, but I'm just as happy returning the array.

[Mr Ekted]

Code: Show/Hide { VoteResults vr; return &vr; }

Yes. Very bad.
_________________
4,691 irradiated haggis!

[CypherJF]

oh duh me rotfl... doh doh doh haaha... i even just answered this one the one exam i just took explainin how the scope would affect such an object.

[Cyan~Fire]

@Bak: That won't work if he wants to save a player's vote after he leaves.
_________________
This help is informational only. No representation is made or warranty given as to its content. User assumes all risk of use. Cyan~Fire assumes no responsibility for any loss or delay resulting from such use.
Wise men STILL seek Him.

[Bak]

@~: You're right, but if you're voting on what game the bot will host next, do you really want to use a player's vote if he or she is not going to play?

Here's a version that doesn't return the array, use would be like

[Cyan~Fire]

@Tansey: You might want to post that on the Wiki's example code page.